[azsdk-cli] Prototype instrumentation for MCP tool calls#11818
Merged
Conversation
benbp
requested review from
jeo02,
l0lawrence,
maririos,
praveenkuttappan,
richardpark-msft,
samvaity,
scbedd,
smw-ms and
timovv
as code owners
github-actions
Bot
added
the
azsdk-cli
praveenkuttappan
approved these changes
Aug 25, 2025
Member
praveenkuttappan
left a comment
praveenkuttappan
left a comment
There was a problem hiding this comment.
Thanks for doing this change
benbp
added
the
Central-EngSys
radhgupta
pushed a commit
to radhgupta/azure-sdk-tools
that referenced
this pull request
Sep 9, 2025
* Demo mcp tool instrumentation * Improve cancellation token usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prototype of an approach to add some static instrumentation wrapper methods to the base
MCPToolclass, and replaces the mcp tool registration logic to call a telemetry wrapper service.I haven't worked this into CLI mode yet because I want to do some higher level refactoring to simplify
GetCommand()andHandleCommand()so we only have to wrap them once at the base.In the future we will switch to the built-in middleware of the mcp c# sdk, but it is currently in development.